handle guzzle response exceptions #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a guzzle client is configured with exceptions=true, try to retrieve the http status code, body size, and network protocol version and set as span attributes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
============================================
+ Coverage 82.13% 82.20% +0.06%
- Complexity 1808 1810 +2
============================================
Files 138 138
Lines 7647 7652 +5
============================================
+ Hits 6281 6290 +9
+ Misses 1366 1362 -4 Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
cedricziel
reviewed
Jun 11, 2025
| try { | ||
| $client->send(new Request('GET', 'https://example.com/error')); | ||
| } catch (\Exception $e) { | ||
| // Expected exception |
There was a problem hiding this comment.
i wonder if we could expectException here
There was a problem hiding this comment.
I think not, because it would bail out if we didn't catch, and not run all the code after this point.
bobstrecansky
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a guzzle client is configured with exceptions=true, try to retrieve the http status code, body size, and network protocol version and set as span attributes
Closes: open-telemetry/opentelemetry-php#1612